#2454 Scrolling by the mouse wheel does not scroll up on the unopened Destination field #2469
+93
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleshchev
approved these changes
Aug 30, 2024
LLGuru
force-pushed
the
guru/viewer-2454-scrolling-by-the-mouse-wheel
branch
from
44f786c
to
2f1ceef
Compare
… Destination field
LLGuru
force-pushed
the
guru/viewer-2454-scrolling-by-the-mouse-wheel
branch
from
2f1ceef
to
96ade1f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The destination list is
The current implementation of the
handleScrollWheel()method is getting stuck on the disabled itemand loses the selection, and after losing the selection this implementation even doesn't try to do anything
The proposed solution is based on using new methods
selectNextItem()andselectPrevItem()in a cycle